Skip to content

Conversation

@araujogui
Copy link
Member

Fixes #61235

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Jan 8, 2026
@araujogui araujogui force-pushed the sqlite-prepare-options branch from 900cba1 to b62c50e Compare January 8, 2026 01:45
@araujogui araujogui force-pushed the sqlite-prepare-options branch from b62c50e to 9bca95a Compare January 8, 2026 01:51
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 84.81013% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.51%. Comparing base (842448b) to head (faaec9f).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 84.81% 7 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61311      +/-   ##
==========================================
+ Coverage   88.00%   88.51%   +0.51%     
==========================================
  Files         704      704              
  Lines      208739   208818      +79     
  Branches    40196    40292      +96     
==========================================
+ Hits       183706   184841    +1135     
+ Misses      16992    15982    -1010     
+ Partials     8041     7995      -46     
Files with missing lines Coverage Δ
src/node_sqlite.h 80.39% <ø> (ø)
src/node_sqlite.cc 80.32% <84.81%> (+0.15%) ⬆️

... and 98 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334

This comment was marked as resolved.

@araujogui araujogui force-pushed the sqlite-prepare-options branch from bb33e58 to 6da81dd Compare January 8, 2026 20:30
@araujogui araujogui requested a review from Renegade334 January 8, 2026 20:31
@araujogui araujogui force-pushed the sqlite-prepare-options branch from 45a8e19 to faaec9f Compare January 8, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlite: db.prepare(sql, options)

3 participants