Skip to content

Conversation

@vmoroz
Copy link
Member

@vmoroz vmoroz commented Jan 9, 2026

This is a comment-only change that does not affect the actual code.
The PR updates a number of comments and test strings where we still use NAPI and N-API instead of the Node-API.
In some cases, the comments are reflowed by the formatter after the changes.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/node-api
  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 9, 2026
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (842448b) to head (b6b3d6d).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61320      +/-   ##
==========================================
+ Coverage   88.00%   88.51%   +0.51%     
==========================================
  Files         704      704              
  Lines      208739   208739              
  Branches    40196    40277      +81     
==========================================
+ Hits       183706   184771    +1065     
+ Misses      16992    15972    -1020     
+ Partials     8041     7996      -45     
Files with missing lines Coverage Δ
src/js_native_api_v8.cc 76.49% <ø> (ø)
src/js_native_api_v8_internals.h 0.00% <ø> (ø)
src/node_api.cc 75.15% <100.00%> (ø)
src/node_binding.cc 82.74% <ø> (ø)

... and 94 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller added node-api Issues and PRs related to the Node-API. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 9, 2026
@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2026
@legendecas legendecas moved this from Need Triage to In Progress in Node-API Team Project Jan 9, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2026
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

7 participants