Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8629 +/- ##
==========================================
- Coverage 75.09% 75.05% -0.05%
==========================================
Files 104 104
Lines 9088 9088
Branches 314 315 +1
==========================================
- Hits 6825 6821 -4
- Misses 2261 2265 +4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR implements a consistent max-width constraint for the NavBar and Footer components by introducing an innerContainer wrapper div with max-w-10xl class in both components. This aligns these components with the main content's width constraints, improving readability on extra-wide screens.
Changes:
- Added
innerContainerwrapper to NavBar and Footer withmax-w-10xlclass for consistent content width - Refactored CSS module nesting to wrap existing styles within
innerContainerselector - Renamed import from
styletostylesin NavBar for consistency
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui-components/src/Containers/NavBar/index.tsx | Added innerContainer wrapper div and updated import name from style to styles for consistency |
| packages/ui-components/src/Containers/NavBar/index.module.css | Restructured CSS with innerContainer class containing max-w-10xl constraint and nested all child selectors within it |
| packages/ui-components/src/Containers/Footer/index.tsx | Added innerContainer wrapper div and refactored from explicit to implicit return |
| packages/ui-components/src/Containers/Footer/index.module.css | Restructured CSS with innerContainer class containing max-w-10xl constraint and nested all child selectors within it |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Build Size ComparisonSummary
Changes➕ Added Assets (5)
➖ Removed Assets (5)
|
|
cc @nodejs/nodejs-website |
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
|
cc @nodejs/nodejs-website requesting fast-track :) 👍 to approve, 👎 to not approve |
2 participants
This PR changes the design of NavBar and Footer so their max-width is also the same from main content, aligning the design and keeping it easier to read for extra wide screens.