fix: use latin1 encoding for headers in WrapHandler#4798
Open
fix: use latin1 encoding for headers in WrapHandler#4798
Conversation
WrapHandler was converting header strings to Buffers using Buffer.from() without specifying an encoding, which defaults to UTF-8. HTTP headers must use Latin1 (ISO-8859-1) encoding instead. Fixes: #4797
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4798 +/- ##
==========================================
- Coverage 93.25% 93.24% -0.02%
==========================================
Files 109 109
Lines 34024 34100 +76
==========================================
+ Hits 31729 31796 +67
- Misses 2295 2304 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WrapHandlerto use Latin1 encoding when converting header strings to BuffersBuffer.from(val)which defaults to UTF-8, causing header values with non-ASCII bytes to be incorrectly encodedonRequestUpgrade,onResponseStart, andonResponseEndmethodsFixes #4797
Test plan