Add missing close method to WebSocketStream interface#4802
Merged
KhafraDev merged 1 commit intonodejs:mainfrom Feb 3, 2026
Merged
Add missing close method to WebSocketStream interface#4802KhafraDev merged 1 commit intonodejs:mainfrom
close method to WebSocketStream interface#4802KhafraDev merged 1 commit intonodejs:mainfrom
Conversation
KhafraDev
approved these changes
Feb 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4802 +/- ##
==========================================
- Coverage 93.24% 93.23% -0.01%
==========================================
Files 109 109
Lines 34100 34100
==========================================
- Hits 31796 31793 -3
- Misses 2304 2307 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
This adds missing close method to WebSocketStream interface, (see MDN Reference).
Method is already defined, but missing in interface:
undici/lib/web/websocket/stream/websocketstream.js
Lines 185 to 198 in 6cc668d
Changes
See diff
Features
N/A if not
Bug Fixes
N/A
Breaking Changes and Deprecations
No breaking changes
Status