fix: handle schema-less HTTP_PROXY env vars#4809
Open
M-YasirGhaffar wants to merge 1 commit intonodejs:mainfrom
Open
fix: handle schema-less HTTP_PROXY env vars#4809M-YasirGhaffar wants to merge 1 commit intonodejs:mainfrom
M-YasirGhaffar wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: M-YasirGhaffar <yasirghaffar.nust@gmail.com>
Member
|
cc @joyeecheung can you take a look as well? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4809 +/- ##
==========================================
- Coverage 93.26% 93.26% -0.01%
==========================================
Files 109 109
Lines 34090 34098 +8
==========================================
+ Hits 31794 31800 +6
- Misses 2296 2298 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Will this require adjustments in Node for |
Author
|
@metcoder95 This shouldn't require any changes for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #4736
Rationale
When HTTP_PROXY or HTTPS_PROXY is set without a URL scheme (e.g., localhost:8080 instead of http://localhost:8080), the EnvHttpProxyAgent fails. This PR adds automatic http:// prefix for schema-less proxy URLs, matching Go's httpproxy behavior.
Changes
Added normalizeProxyUrl() helper function in lib/dispatcher/env-http-proxy-agent.js. Also added tests in test/env-http-proxy-agent.js.
Features
N/A
Bug Fixes
Breaking Changes and Deprecations
None. This is additive behavior - existing URLs with explicit schemes are unchanged.
Status