Skip to content

Comments

fix: upgrade conjure-plugin config to v2 to enable stale file cleanup#6

Merged
Leundai merged 1 commit intomainfrom
fix/enable-stale-conjure-cleanup
Feb 22, 2026
Merged

fix: upgrade conjure-plugin config to v2 to enable stale file cleanup#6
Leundai merged 1 commit intomainfrom
fix/enable-stale-conjure-cleanup

Conversation

@Leundai
Copy link
Contributor

@Leundai Leundai commented Feb 10, 2026

Summary

  • Upgrade godel-conjure-plugin from 6.84.0 to 6.104.0 (v6.96.0+ required for v2 config support)
  • Upgrade conjure-plugin.yml from version 1 to version 2 with output-dir: . and omit-top-level-project-dir: true
  • Regenerate all Go code with the new plugin version
  • Stale files automatically cleaned up (the root cause of the CI failure)

Context

The go-publish workflow in scout has been failing on every release since Jan 26 (~47 consecutive failures since combined-service@0.1082.1).

scout PR #10689 removed the LogicalSeriesService from the Conjure spec and renamed types (e.g. LogicalSeriesExternalStorageLocator). When ./godelw conjure runs, it regenerates the type files with new names but does not delete the stale timeseries/logicalseries/services.conjure.go — causing the Go build to fail with:

undefined: api.CreateLogicalSeries
undefined: api.LogicalSeries
undefined: api.BatchCreateLogicalSeriesRequest
...

Root cause: godel-conjure-plugin has built-in stale file cleanup via computeFilesToDelete(), but:

  1. It requires a v2 config (v1 configs hardcode skip-delete-generated-files: true during internal upgrade)
  2. v2 config support was only added in v6.96.0 (repo was on 6.84.0)
  3. v2 defaults to a different output directory (internal/generated/conjure/), so we set output-dir: . and omit-top-level-project-dir: true to preserve the existing file layout

Stale files removed

Key deletions (services/types removed from Conjure spec but lingering in the Go client):

  • timeseries/logicalseries/services.conjure.go (the direct cause of CI failure)
  • timeseries/archetype/ (entire directory — service was removed)
  • datasource/logset/ (entire directory — service was removed)
  • ingest/workflow/api/services.conjure.go
  • Various embed.conjure.go and extensions.conjure.json files no longer generated by the new plugin version

Verified locally

$ ./godelw conjure   # stale services.conjure.go deleted
$ go mod tidy
$ go build ./...     # EXIT CODE: 0

Test plan

  • Verified go build ./... passes locally after regeneration
  • Merge this PR, then trigger go-publish workflow in scout (or wait for next release tag)
  • Confirm the workflow passes end-to-end

🤖 Generated with Claude Code

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@Leundai Leundai force-pushed the fix/enable-stale-conjure-cleanup branch 2 times, most recently from 143bc9c to d1c4581 Compare February 10, 2026 19:10
@Leundai Leundai requested review from a team and helenyugithub February 10, 2026 19:12
… cleanup

Upgrade godel-conjure-plugin from 6.84.0 to 6.104.0 and switch to v2
config format with output-dir and omit-top-level-project-dir to preserve
existing file layout while enabling automatic stale file cleanup.

This fixes the go-publish CI failures caused by stale generated files
(e.g. timeseries/logicalseries/services.conjure.go) that reference
removed Conjure types.
@Leundai Leundai force-pushed the fix/enable-stale-conjure-cleanup branch from d1c4581 to ed8ff69 Compare February 22, 2026 21:11
@Leundai Leundai merged commit 8053808 into main Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants