fix: upgrade conjure-plugin config to v2 to enable stale file cleanup#6
Merged
fix: upgrade conjure-plugin config to v2 to enable stale file cleanup#6
Conversation
143bc9c to
d1c4581
Compare
… cleanup Upgrade godel-conjure-plugin from 6.84.0 to 6.104.0 and switch to v2 config format with output-dir and omit-top-level-project-dir to preserve existing file layout while enabling automatic stale file cleanup. This fixes the go-publish CI failures caused by stale generated files (e.g. timeseries/logicalseries/services.conjure.go) that reference removed Conjure types.
d1c4581 to
ed8ff69
Compare
helenyugithub
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
godel-conjure-pluginfrom 6.84.0 to 6.104.0 (v6.96.0+ required for v2 config support)conjure-plugin.ymlfrom version 1 to version 2 withoutput-dir: .andomit-top-level-project-dir: trueContext
The
go-publishworkflow in scout has been failing on every release since Jan 26 (~47 consecutive failures sincecombined-service@0.1082.1).scout PR #10689 removed the
LogicalSeriesServicefrom the Conjure spec and renamed types (e.g.LogicalSeries→ExternalStorageLocator). When./godelw conjureruns, it regenerates the type files with new names but does not delete the staletimeseries/logicalseries/services.conjure.go— causing the Go build to fail with:Root cause:
godel-conjure-pluginhas built-in stale file cleanup viacomputeFilesToDelete(), but:skip-delete-generated-files: trueduring internal upgrade)internal/generated/conjure/), so we setoutput-dir: .andomit-top-level-project-dir: trueto preserve the existing file layoutStale files removed
Key deletions (services/types removed from Conjure spec but lingering in the Go client):
timeseries/logicalseries/services.conjure.go(the direct cause of CI failure)timeseries/archetype/(entire directory — service was removed)datasource/logset/(entire directory — service was removed)ingest/workflow/api/services.conjure.goembed.conjure.goandextensions.conjure.jsonfiles no longer generated by the new plugin versionVerified locally
Test plan
go build ./...passes locally after regenerationgo-publishworkflow in scout (or wait for next release tag)🤖 Generated with Claude Code