Conversation
…file, Add methods to remove obsolete entities and relations
* Refactor code for the Famic Class creation * Connect vscode extension with ts2famix changes * Add neverthrow library, Throw the error when the tsconfig file is not found * Add better error handling for commands, Add response type for commands * Add the test cases list * Rename 'createOrGetFamixClass' method to 'ensureFamixClass' method
* Add the source anchor deletion implementation * Refactor inheritance and interface creation * Add a FullyQualifiedNameEntity interface * Add catching the error for the extension incremental update * Update README.md * Split SourcedEntity class into 2 classes: SourcedEntity and EntityWithSourceAnchor
* Add tests and incremental update for property
* Add the source anchor deletion implementation * Refactor inheritance and interface creation * Add a FullyQualifiedNameEntity interface * Split SourcedEntity class into 2 classes: SourcedEntity and EntityWithSourceAnchor * Add tests for import clause * Implement ImportClause for named imports. Add incremental update for the imported entities (Inheritance and ImportClause). ---------------------------- Still need to resolve the issue with: - re-export - the cases when we choose to create the module over a file - finish file and module Famix elements creation, add tests - implement ImportClause for other types of imports * Add reexport tests * Add namespace import tests * Add implementation for the Import Clause for - named import/export; - namespace import/export; - reexport. Encapsulate ImportClause creation logic in a separate file * Add test with exporting interfaces for the inheritance * Remove the old ImportClause test * Fix getFamixEntityByFullyQualifiedName to work with all the entities that have fullyQualifiedName field * Fix getModuleSpecifierFromDeclaration to work with import without ts. We still need to verify how does it work with node_modules and import aliases * Add excluding files specified in tsconfig from watching
* Review and fix tests
There was a problem hiding this comment.
Pull Request Overview
This PR implements incremental updating functionality for a TypeScript to Famix model converter, allowing the system to detect file changes and update the model incrementally rather than regenerating the entire model from scratch.
Key changes:
- Added file watching capabilities with VS Code language server integration
- Implemented incremental model updating for TypeScript files through file change detection
- Extended the VS Code extension to support real-time model updates during development
Reviewed Changes
Copilot reviewed 100 out of 101 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| vscode-extension/test-cases.md | Added comprehensive manual test cases for extension activation, command execution, and incremental functionality |
| vscode-extension/server/src/utils.ts | Added utilities for TypeScript project detection, file path handling, and glob pattern creation |
| vscode-extension/server/src/server.ts | Enhanced server initialization with file watching capabilities and project manager integration |
| vscode-extension/server/src/model/ | Created model management classes for Famix project handling, file export, and change tracking |
| vscode-extension/server/src/eventHandlers/ | Implemented file change event handlers for incremental updates |
| vscode-extension/server/src/commandHandlers.ts | Refactored command handling to use project manager and improved error responses |
| vscode-extension/package.json | Updated dependencies and activation events for workspace-based activation |
| vscode-extension/client/src/ | Removed client-side utilities and updated command handling for server-based processing |
| test/ | Added extensive incremental update test suites and updated existing tests with proper skipping |
Files not reviewed (1)
- vscode-extension/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.