Add Serbian (cyrillic & latin) translation#69
Closed
rammba wants to merge 1 commit intonotepad-plus-plus:masterfrom
Closed
Add Serbian (cyrillic & latin) translation#69rammba wants to merge 1 commit intonotepad-plus-plus:masterfrom
rammba wants to merge 1 commit intonotepad-plus-plus:masterfrom
Conversation
Contributor
|
I must admit, I don't know enough about translations to figure this out. |
Member
|
Here are the symbols I found in the header of VSStudio (ntdef.h): ...
#define SUBLANG_SAMI_SOUTHERN_SWEDEN 0x07 // Southern Sami (Sweden)
#define SUBLANG_SAMI_SKOLT_FINLAND 0x08 // Skolt Sami (Finland)
#define SUBLANG_SAMI_INARI_FINLAND 0x09 // Inari Sami (Finland)
#define SUBLANG_SANSKRIT_INDIA 0x01 // Sanskrit (India) 0x044f sa-IN
#define SUBLANG_SCOTTISH_GAELIC 0x01 // Scottish Gaelic (United Kingdom) 0x0491 gd-GB
#define SUBLANG_SERBIAN_BOSNIA_HERZEGOVINA_LATIN 0x06 // Serbian (Bosnia and Herzegovina - Latin)
#define SUBLANG_SERBIAN_BOSNIA_HERZEGOVINA_CYRILLIC 0x07 // Serbian (Bosnia and Herzegovina - Cyrillic)
#define SUBLANG_SERBIAN_MONTENEGRO_LATIN 0x0b // Serbian (Montenegro - Latn)
#define SUBLANG_SERBIAN_MONTENEGRO_CYRILLIC 0x0c // Serbian (Montenegro - Cyrillic)
#define SUBLANG_SERBIAN_SERBIA_LATIN 0x09 // Serbian (Serbia - Latin)
#define SUBLANG_SERBIAN_SERBIA_CYRILLIC 0x0a // Serbian (Serbia - Cyrillic)
#define SUBLANG_SERBIAN_CROATIA 0x01 // Croatian (Croatia) 0x041a hr-HR
#define SUBLANG_SERBIAN_LATIN 0x02 // Serbian (Latin)
#define SUBLANG_SERBIAN_CYRILLIC 0x03 // Serbian (Cyrillic)
#define SUBLANG_SINDHI_INDIA 0x01 // Sindhi (India) reserved 0x0459
...And your PR seems correct to me: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hello, as a current Serbian translator for N++, I wanted to translate context menu message as well.
I've noticed that translation was introduced in #25. However, since Serbian language is not that popular and widely used I wasn't sure how to implement this properly.
First thing, I didn't know which IBM code to use for cyrillic and latin version of serbian. Based on the IBM docs mentioned in the issue, or its latest version 6, I should use
SRBfor cyrillic andSRLfor latin. However, when I looked into CultureInfo class, it'sThreeLetterWindowsLanguageNamefield says thatSROis for cyrillic andSRMfor latin. I ended up usingAFX_TARG_SROandAFX_TARG_SRM, but I didn't found proper documentation for what should be used.Second thing, I didn't succeed in finding documentation for

SUBLANG_values. I've usedSUBLANG_SERBIAN_SERBIA_CYRILLICandSUBLANG_SERBIAN_SERBIA_LATINwhich should depend onsr-Cyrl-RSandsr-Latn-RSlocales/cultures, but I'm not sure. Only clue that I had iswinnt.hfile that I have on my Windows 10, which has following content: part of winnt content.txt. There you can see comment stating:WARNING: This pattern is broken and not followed for all languages. Serbian, Bosnian & Croatian are a few examples.If you have any clue where this can be found online, it would be great.Problem with that approach is how Visual Studio marks
SUBLANG_SERBIAN_SERBIA_LATIN. For some reason, it doesn't recognize it as a normal string table, while cyrillic version is ok:@GurliGebis, @xomx, @donho do you have any clue where to find documentation about these topics. Sorry, but I never worked that much deep with languages and locales, so I probably missed something.