Skip to content

multiple providers to testing overrides#33

Open
nrbnlulu wants to merge 1 commit intonotypecheck:mainfrom
nrbnlulu:multiple-providers-in-override
Open

multiple providers to testing overrides#33
nrbnlulu wants to merge 1 commit intonotypecheck:mainfrom
nrbnlulu:multiple-providers-in-override

Conversation

@nrbnlulu
Copy link
Contributor

No description provided.

Support multiple provider overrides with both async and sync context
managers for more flexible testing scenarios.
@notypecheck
Copy link
Owner

Don't you think it would be better to make _Override accept multiple providers or make a separate wrapper object returned by TestContainer.override with it's own sync and async context manager methods, instead of changing the api?

@nrbnlulu
Copy link
Contributor Author

TBH I don't like the name of TestContainer it sounds like you are creating a new container I would just do with aioinject.testing.override

instead of changing the api?

the current api is prob wrong, it won't cleanup async singletons afaict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants