Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds test support for Unity's new Input System by introducing a dedicated test scene and accompanying test case. The changes enable testing of UI interactions using the new Input System API alongside the existing input handling tests.
- Adds a comprehensive test scene (
NewInputSystem.unity) with multiple test objects demonstrating various event handler patterns with the new Input System - Introduces Input Actions configuration (
TestInputActions.inputactions) with Player and UI action maps - Adds a test case to verify click operations work correctly with the new Input System
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/TestAssets/TestInputActions.inputactions | Defines Input Actions with Player and UI maps for keyboard, mouse, gamepad, touch, joystick, and XR control schemes |
| Tests/TestAssets/TestInputActions.inputactions.meta | Unity metadata for the Input Actions asset with InputSystem namespace configuration |
| Tests/TestAssets.meta | Unity metadata for the TestAssets directory |
| Tests/Scenes/NewInputSystem.unity | Unity scene containing test objects (UsingOnPointerClickHandler, DestroyItselfIfPointerDown, UsingPointerDownUpEventTrigger, UsingMultipleEventTriggers, UsingPointerClickEventTrigger, UsingOnPointerDownUpHandler) with EventSystem configured for new Input System |
| Tests/Scenes/NewInputSystem.unity.meta | Unity metadata for the test scene |
| Tests/Runtime/Operators/UguiClickOperatorTest.cs | Adds test case OperateAsync_NewInputSystem_InvokeOnClick to verify click operator functionality with new Input System |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Metrics Report
Details | | master (043f2af) | #288 (b44a2b9) | +/- |
|---------------------|------------------|----------------|--------|
| Coverage | 88.9% | 88.9% | 0.0% |
| Files | 70 | 70 | 0 |
| Lines | 2557 | 2557 | 0 |
| Covered | 2275 | 2275 | 0 |
+ | Code to Test Ratio | 1:1.3 | 1:1.3 | +0.0 |
| Code | 4578 | 4578 | 0 |
+ | Test | 6103 | 6112 | +9 |
- | Test Execution Time | 12m41s | 15m10s | +2m29s |Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.