Skip to content

Add more Berlin companies#16

Open
l3d00m wants to merge 3 commits intonoyainrain:mainfrom
l3d00m:main
Open

Add more Berlin companies#16
l3d00m wants to merge 3 commits intonoyainrain:mainfrom
l3d00m:main

Conversation

@l3d00m
Copy link

@l3d00m l3d00m commented Jun 7, 2024

@noyainrain noyainrain added enhancement New feature or request Berlin labels Jun 9, 2024
@noyainrain
Copy link
Owner

Amazing, thank you for your contribution! 💖 I'll give it a try in the next few days, latest next week. 🙂

I had a quick look at Immonexxt, seems okay to me. 😉

@noyainrain noyainrain self-assigned this Jun 10, 2024
@noyainrain
Copy link
Owner

Hey there, sorry for the unexpected delay! Something health-related came up and I had an urgent surgery. But recovery went well, and I'm back again. 😌

@l3d00m
Copy link
Author

l3d00m commented Jul 13, 2024

Oh no, all the best to you! Take your time with this. I did find an apartment as well, but I'd still be willing to resolve any suggestions you might have.

I actually found the WBM parser the most helpful, since they have some kind of "first comes, first served", so your tool really helped. (I did build a really hacky telegram integration into this)

Copy link
Owner

@noyainrain noyainrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the original contribution / first commit and overall it looks good! 👌

I've noticed that the links for Immonexxt and Harry Gerlach are broken. Investigating a bit, that's because both sites use a <base> tag, which we don't handle yet. So, we first have to implement #17 . If you'd like to give it a shot, please feel more than welcome to! (I can also help if there are questions) Otherwise I'll do it in the near future. 😊

For the later commits: Could you split them into their own PRs? That would make it way easier for me to test and merge them bit by bit. Thanks again for your work! 😊

@noyainrain
Copy link
Owner

I did find an apartment as well, but I'd still be willing to resolve any suggestions you might have.

Congrats on finding an apartment! 🥳

I actually found the WBM parser the most helpful, since they have some kind of "first comes, first served", so your tool really helped. (I did build a really hacky telegram integration into this)

If you want to share a little about how you built the Telegram integration, feel free to hop into our Discord, I'm sure some poeple would find that interesting (me included 😉 )

@l3d00m
Copy link
Author

l3d00m commented Jul 15, 2024

For the later commits: Could you split them into their own PRs? That would make it way easier for me to test and merge them bit by bit. Thanks again for your work! 😊

Done!

@l3d00m
Copy link
Author

l3d00m commented Jul 15, 2024

I've noticed that the links for Immonexxt and Harry Gerlach are broken. Investigating a bit, that's because both sites use a <base> tag, which we don't handle yet. So, we first have to implement #17 . If you'd like to give it a shot, please feel more than welcome to! (I can also help if there are questions) Otherwise I'll do it in the near future. 😊

I think that's a bit too big of a scope for me, so i'd appreciate you doing that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Berlin blocked enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants