please do not use#164
Conversation
* Update index.js * Update basic.js.test.cjs * Update basic.js.test.cjs
|
@wraithgar sorry to ping directly, but please let me know your feedback on this and I'll look into adding test |
|
This would be a semver major change for npm and a semver major change for nodejs |
I'm confused, this PR is a semver major change, or this PR fixes a semver major change? |
First one - this is a semver major change I repeated semver major change for nodejs to emphasize that it shouldn't go in with a nodejs minor release |
|
Ok, next question: is that just for this repo or will that semver-major change bubble up to npm itself? Put another way, will we be able to edit npm's code to handle this change gracefully? I suppose though if it's going to be semver major for node itself the point is irrelevant. Unless I'm missing something I don't see how this can go in with npm 11. We may have to wait till npm 12. |
|
@wraithgar yeah npm 12 sounds good to me the version of cmd-shim in npm will need to have its version bumped
|
|
I have added a comment to npm/statusboard#930. That's where we are tracking our future breaking changes. npm 12 is not currently on a roadmap but that issue will get more activity when that time comes. |
|
Given npm/cli#8532, either way let's not move forward with this PR |
DO NOT USE