This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix: Relative GitHub paths when a directory is specified#455
Open
mofojed wants to merge 1 commit intonpm:masterfrom
Open
fix: Relative GitHub paths when a directory is specified#455mofojed wants to merge 1 commit intonpm:masterfrom
mofojed wants to merge 1 commit intonpm:masterfrom
Conversation
- Check for the `directory` property on the repository, for when package.json is not at the root: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#repository - Convert the relative path correctly to where the file is located in GitHub
mofojed
added a commit
to mofojed/web-client-ui
that referenced
this pull request
Mar 7, 2022
npmjs doesn't handle the `directory` spec in package.json when building links. I've made a separate PR to fix that, but I doubt it will ever be merged: npm/marky-markdown#455 Workaround is to just use absolute links.
dsmmcken
pushed a commit
to deephaven/web-client-ui
that referenced
this pull request
Mar 11, 2022
npmjs doesn't handle the `directory` spec in package.json when building links. I've made a separate PR to fix that, but I doubt it will ever be merged: npm/marky-markdown#455 Workaround is to just use absolute links.
mofojed
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
directoryproperty on the repository, for when package.json is not at the root: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#repository