Create the discussion board and the option to add a new discussion by rachel-yos · Pull Request #44 · npmStart0/client

rachel-yos · 2025-02-25T15:16:26Z

The task contains a few components:

The page of all the discussion are related to a specific selected topic.
The discussion component, will apear as number of the existing discussions.
The create a new discussion button will apear twice, and this opens a dialog box to enter the new discussion details.
The dialog box to create the new discussion
Create Page to Display Discussions on a Specific Subject with New Discussion Option #41

DvoraShechter1

LOTM!
please wait for @RutiRozenberg approve

RutiRozenberg · 2025-03-20T21:52:54Z

Link the PR to the appropriate Issue, and attach a screenshot of the final result.

RutiRozenberg

Overall, your code is excellent and works flawlessly. The comments provided are meant to enhance clarity and maintainability. I appreciate the effort you've put in, and with a few adjustments, it will be even better. Great job!

RutiRozenberg · 2025-03-27T10:14:27Z

src/components/ActiveControl.jsx

+                borderRadius: '182.5px',
+                paddingTop:0.2,
+                paddingBottom:0.2,
+                color:'white',


Use the ThemeColor Object.

RutiRozenberg · 2025-03-27T10:22:36Z

src/components/ActiveControl.jsx

+                paddingBottom:0.2,
+                color:'white',
+                paddingRight:2.4,
+                paddingLeft:2.4


It seems that you've defined the padding properties in multiple lines. To improve readability and make the code more concise, combine them into a single line.
For example: padding: '0.2 2.4 0.2 2.4'
This way, it will be cleaner and more professional.

RutiRozenberg · 2025-03-27T10:49:23Z

src/components/Discussion.jsx

+export const Discussion = ({ props }) => {
+
+    const theme = useTheme();
+


Please remove unnecessary line.

RutiRozenberg · 2025-03-27T10:49:34Z

src/components/Discussion.jsx

+    fontWeight: 700,
+    letterSpacing: 1.3,
+    fontSize: '1.42em',
+


Please remove unnecessary line.

RutiRozenberg · 2025-03-27T12:11:38Z

src/components/Discussion.jsx

+import { Button, Typography, useTheme } from '@mui/material';
+import { useNavigate } from 'react-router';
+
+const typographyStyle = {


Great job using global reusable code! This aligns with the DRY principle and enhances code readability and maintainability. Keep it up!

RutiRozenberg · 2025-03-27T12:57:30Z

src/components/DiscussionBoard.jsx

+
+            <ActiveControl props={{ title: 'יצירת דיון חדש' }} onOpen={Open} sx={{
+                // position: 'absolute', top: '10%'
+            }}></ActiveControl>


Each property should be written on a separate line for better readability.

RutiRozenberg · 2025-03-27T12:58:09Z

src/components/NewDiscussion.jsx

+            </Typography>
+            <Typography
+                sx={{
+                    ...typhographyStyle, ml: '36.4vw'


Each property should be written on a separate line for better readability.

RutiRozenberg · 2025-03-27T12:58:19Z

src/components/NewDiscussion.jsx

+            />
+            <Typography
+                sx={{
+                    ...typhographyStyle, ml: '32vw'


Each property should be written on a separate line for better readability.

RutiRozenberg · 2025-03-27T12:58:48Z

src/components/NewDiscussion.jsx

+                rows={7}
+                className="css-16wblaj-MuiInputBase-input-MuiOutlinedInput"
+                sx={{
+                    ...textFieldStyle, mb: 3


Each property should be written on a separate line for better readability.

RutiRozenberg · 2025-03-27T13:01:38Z

src/components/DiscussionBoard.jsx

+    0 0 200px #49ACEF,
+    0 0 300px #49ACEF`,
+                    }}
+                >


Please update the textShadow property to ensure proper indentation and readability

rachel-yos added 4 commits February 25, 2025 17:07

add create new discussion button

d440bff

add Discussion.jsx component

bb5dfe4

add DiscussionBoard.jsx and the newDiscussion.jsx

641ff07

change routing and themeColors

a7b4950

DvoraShechter1 reviewed Mar 20, 2025

View reviewed changes

add NewDiscussion.jsx

91a5f6b

rachel-yos changed the title ~~Create the discussion board and the option to add a new discussion~~ Create the discussion board and the option to add a new discussion #41 Mar 27, 2025

rachel-yos changed the title ~~Create the discussion board and the option to add a new discussion #41~~ Create the discussion board and the option to add a new discussion Mar 27, 2025

RutiRozenberg requested changes Mar 27, 2025

View reviewed changes

rachel-yos added 3 commits April 21, 2025 10:26

add close icon button

68191be

remove scrolling

58b57bf

change position to be fixed

b961a8a

		export const Discussion = ({ props }) => {

		const theme = useTheme();

Conversation

rachel-yos commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DvoraShechter1 left a comment

Choose a reason for hiding this comment

Uh oh!

RutiRozenberg commented Mar 20, 2025

Uh oh!

RutiRozenberg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rachel-yos commented Feb 25, 2025 •

edited

Loading