View all comment for a particular discussion#22
Open
MichalYiloz wants to merge 2 commits intonpmStart0:devfrom
Open
View all comment for a particular discussion#22MichalYiloz wants to merge 2 commits intonpmStart0:devfrom
MichalYiloz wants to merge 2 commits intonpmStart0:devfrom
Conversation
DvoraShechter1
requested changes
Feb 13, 2025
Member
DvoraShechter1
left a comment
DvoraShechter1
left a comment
There was a problem hiding this comment.
LGTM!
Please pay attention to the minor note below
| else | ||
| { | ||
| List<Comment> comments = new List<Comment>(); | ||
| foreach (var item in discussion.Comments) |
Member
There was a problem hiding this comment.
Please use a lambda expression:
return discussion.Comments.Where(item => item.DiscussionId == Id).ToList();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a function in the DAL called GetListCommentByIdDiscussionAsync
which returns a list of Comment by Discussion Id.
The function call is:
http://localhost:5131/api/Discussion/allComment/{Id}
my issues: #21
thanks!