-
-
Notifications
You must be signed in to change notification settings - Fork 178
feat: changelog button #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
| function getReleaseUrl(ref: RepoRef, tag: string): string { | ||
| const encodedTag = encodeURIComponent(tag) | ||
|
|
||
| switch (ref.provider) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does tangled.sh have release pages? Do we have some better pattern for this or prior art?
| const host = ref.host ?? 'codeberg.org' | ||
| return `https://${host}/api/v1/repos/${ref.owner}/${ref.repo}/releases/tags/${encodedTag}` | ||
| } | ||
| // Bitbucket, Sourcehut, Gitee, Tangled, Radicle don't have easy release tag APIs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an assumption I am making, I could use some help here on reality
|
Looks very good and this does help making the changelog page and thanks for figuring out each of the release api's of the different repository services as it'll make it easier to make adapters. |
Adds a changelog button to the package due
The approach I am using here is pretty similar to the one used by npm-fetch-changelog for fetching changelogs
Relates to #501