Skip to content

chore: build project before playwright test #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 5 commits into from
Feb 3, 2026
Merged

chore: build project before playwright test #777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2591d77
chore: build project before playwright test
mihkeleidast Feb 2, 2026
61f4c3e
ci: add build step before playwright test
danielroe Feb 3, 2026
0b490bb
Merge remote-tracking branch 'origin/main' into build-before-playwright
danielroe Feb 3, 2026
eb0f1e2
fix: keep test:browser behaviour the same + add new test:browser:preb…
danielroe Feb 3, 2026
2a8e842
Apply suggestion from @danielroe
danielroe Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,11 @@ jobs:
- name: 📦 Install dependencies
run: pnpm install

- name: 🏗️ Build project
run: pnpm build:playwright

- name: 🖥️ Test project (browser)
run: pnpm test:browser
run: pnpm test:browser:prebuilt

a11y:
runs-on: ubuntu-latest
Expand Down
10 changes: 6 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"scripts": {
"build": "nuxt build",
"build:lunaria": "node ./lunaria/lunaria.ts",
"build:playwright": "NODE_ENV=test pnpm build",
Copy link
Contributor Author

@mihkeleidast mihkeleidast Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure where the NODE_ENV matters, kept it for both for now

"dev": "nuxt dev",
"dev:docs": "pnpm run --filter npmx-docs dev --port=3001",
"i18n:check": "node scripts/compare-translations.ts",
Expand All @@ -27,13 +28,14 @@
"postinstall": "nuxt prepare && simple-git-hooks && pnpm generate:lexicons",
"generate:lexicons": "lex build --lexicons lexicons --out shared/types/lexicons --clear",
"test": "vite test",
"test:browser": "playwright test",
"test:browser:ui": "playwright test --ui",
"test:browser:update": "playwright test --update-snapshots",
"test:browser": "pnpm build:playwright && pnpm test:browser:prebuilt",
"test:browser:prebuilt": "playwright test",
"test:browser:ui": "pnpm build:playwright && pnpm test:browser:prebuilt --ui",
"test:browser:update": "pnpm build:playwright && pnpm test:browser:prebuilt --update-snapshots",
"test:nuxt": "vite test --project nuxt",
"test:types": "nuxt prepare && vue-tsc -b --noEmit && pnpm --filter npmx-connector test:types",
"test:unit": "vite test --project unit",
"start:playwright:webserver": "NODE_ENV=test pnpm build && pnpm preview --port 5678"
"start:playwright:webserver": "NODE_ENV=test pnpm preview --port 5678"
},
"dependencies": {
"@atproto/api": "^0.18.17",
Expand Down
2 changes: 1 addition & 1 deletion playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default defineConfig<ConfigOptions>({
command: 'pnpm start:playwright:webserver',
url: baseURL,
reuseExistingServer: false,
timeout: 240_000,
timeout: 60_000,
},
use: {
baseURL,
Expand Down
Loading