a117: extract explicit tag components with enforce a11y #779
+224
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
danielroe
reviewed
Feb 2, 2026
danielroe
reviewed
Feb 2, 2026
danielroe
reviewed
Feb 2, 2026
| </script> | ||
|
|
||
| <template> | ||
| <span v-if="disabled" class="opacity-50"><slot /></span> |
Member
There was a problem hiding this comment.
we should probably have a number of the other styles so it looks visually similar or you'd experience layout shift when disabling a button
Contributor
Author
There was a problem hiding this comment.
Yes, this was a quick one, because this isn't used anywhere yet. Just wanted to sketch it out.
Member
|
conceptually this seems good to me 👍 |
This reverts commit f0876f4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the existing
TagClickableinto 3 specific components:TagButtonTagLinkTagRadioButtomAll have their own implementation and enforce proper usage especially with respect a11y.
The idea is that their implementation should only be touched when updating the design system, needing to extend them or wanting to prevent misusage. Their are explicit strict and not flexible, so they can only be used as intended (no
<a href="" type="button">).The tag component here is an example if this is a pattern we want to continue with. I am leaving the PR as a draft for now, so we can have some discussion about wether or not this is a good direction.