Skip to content

chore: fix navigation to home #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
iiio2 wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −8
Draft

chore: fix navigation to home #798

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea88a00
chore: fix navigation to home
iiio2 Feb 3, 2026
0ba62bb
chore: update
iiio2 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions app/components/AppHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,12 @@ onKeyStroke(
class="container min-h-14 flex items-center gap-2"
:class="isOnHomePage ? 'justify-end' : 'justify-between'"
>
<!-- Mobile: Logo + search button (expands search, doesn't navigate) -->
<button
<!-- Mobile: Logo (navigates home) -->
<NuxtLink
v-if="!isSearchExpanded && !isOnHomePage"
type="button"
class="sm:hidden flex-shrink-0 inline-flex items-center gap-2 font-mono text-lg font-medium text-fg hover:text-fg transition-colors duration-200 focus-ring rounded"
:aria-label="$t('nav.tap_to_search')"
@click="expandMobileSearch"
to="/"
:aria-label="$t('header.home')"
class="sm:hidden flex-shrink-0 font-mono text-lg font-medium text-fg hover:text-fg transition-colors duration-200 focus-ring rounded"
>
<img
aria-hidden="true"
Expand All @@ -107,8 +106,7 @@ onKeyStroke(
height="96"
class="w-8 h-8 rounded-lg"
/>
<span class="i-carbon:search w-4 h-4 text-fg-subtle" aria-hidden="true" />
</button>
</NuxtLink>

<!-- Desktop: Logo (navigates home) -->
<div v-if="showLogo" class="hidden sm:flex flex-shrink-0 items-center">
Expand Down Expand Up @@ -199,6 +197,17 @@ onKeyStroke(
<HeaderAccountMenu />
</div>

<!-- Mobile: Search button (expands search) -->
<button
v-if="!isSearchExpanded && !isOnHomePage"
type="button"
class="sm:hidden flex items-center p-2 -m-2 text-fg-subtle hover:text-fg transition-colors duration-200 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent/50 rounded"
:aria-label="$t('nav.tap_to_search')"
@click="expandMobileSearch"
>
<span class="i-carbon:search w-6 h-6" aria-hidden="true" />
</button>

<!-- Mobile: Menu button (always visible, toggles menu) -->
<button
type="button"
Expand Down
Loading