fix: for ? allow access with modifiers
#809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#607 seems to have introduced a regression where the "?" keyboard shortcut no longer works (because the shift modifier is required on standard keyboards). @serhalp I considered if we should add a util for modifier keyboard combinations, but I'm not sure about it tbh. Both because afaik the
keyproperty should be robust in this case, but I'm generally also not fond of making abstractions when I do not yet have a pattern (like we only need this in a single instance currently). Wdyt?