Open
Conversation
“Enter user name?”, with a question mark, is a question to which the answer is either “yes” or “no”, not a username. Therefore, I removed the question mark. (Another possibility would be to simply ask: “What’s your username?”) Also, the Oxford Dictionary of English gives the compound word “username” to refer to "an identification used by a person with access to a computer, network, or online service,” which I suppose it’s the meaning intended here. I respelled it like that.
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=========================================
- Coverage 98.93% 96.6% -2.34%
=========================================
Files 11 39 +28
Lines 936 1912 +976
Branches 0 63 +63
=========================================
+ Hits 926 1847 +921
- Misses 10 65 +55
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
“Enter user name?”, with a question mark, is a question to which the answer is either “yes” or “no,” not a username. Accordingly, I removed the question mark. (Another possibility would be to simply ask: “What’s your username?”)
Also, the Oxford Dictionary of English gives the compound word “username” to refer to "an identification used by a person with access to a computer, network, or online service,” which I suppose it’s the meaning intended here. I rewrote it like that.