Conversation
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3473 +/- ##
==========================================
+ Coverage 22.96% 22.98% +0.02%
==========================================
Files 669 669
Lines 50083 50089 +6
==========================================
+ Hits 11501 11514 +13
+ Misses 37681 37676 -5
+ Partials 901 899 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Jul 17, 2025
342c6cb to
fc0f210
Compare
Make cleaner tests code, remove duplication. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the FSTree test code by extracting common functionality into a shared file and adding new comprehensive benchmarks. The main purpose is to reduce code duplication across test files and expand test coverage with additional benchmark scenarios.
Key changes include:
- Creation of a common test utilities file to consolidate shared functions
- Addition of comprehensive benchmarks for Head, Get, and GetStream operations
- Refactoring of existing benchmark tests to use the new shared utilities
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
common_test.go |
New file containing shared test utilities and helper functions |
bench_test.go |
New comprehensive benchmark suite for FSTree operations |
head_bench_test.go |
Refactored to use common utilities, removed duplicate code |
head_test.go |
Refactored to use common utilities, moved shared function to common file |
range_bench_test.go |
Refactored to use common utilities, cleaned up duplicate setup code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #3451.