Draft
Conversation
1. If any shard returns something like "object is locked" it's final, there is no point in continuing iterations. 2. Wrap and return the last error from the method, don't lose it. 3. Simplify putToShard signature, single error is sufficient here. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3688 +/- ##
==========================================
- Coverage 27.34% 27.31% -0.04%
==========================================
Files 658 658
Lines 41713 41649 -64
==========================================
- Hits 11407 11376 -31
+ Misses 29246 29215 -31
+ Partials 1060 1058 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure draft for tests