Support setAttribute container contract method#3728
Closed
Conversation
smallhive
requested review from
End-rey,
carpawell,
cthulhu-rider and
roman-khimov
as code owners
smallhive
force-pushed
the
notary-set-attribute
branch
from
ac904c2 to
18979b1
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3728 +/- ##
==========================================
- Coverage 26.88% 26.85% -0.04%
==========================================
Files 658 659 +1
Lines 41829 41873 +44
==========================================
- Hits 11246 11243 -3
- Misses 29548 29595 +47
Partials 1035 1035 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| cp.log.Debug("notification", | ||
| zap.String("type", "set attribute"), | ||
| zap.String("cID", string(e.CID)), |
Contributor
There was a problem hiding this comment.
Suggested change
| zap.String("cID", string(e.CID)), | |
| zap.String("cID", base58.Encode(e.CID)), |
| err := cp.cnrClient.Morph().NotarySignAndInvokeTX(e.NotaryRequest.MainTransaction, false) | ||
| if err != nil { | ||
| cp.log.Error("could not approve set attribute", | ||
| zap.String("cID", string(e.CID)), |
| } | ||
|
|
||
| err := cp.objectPool.Submit(func() { | ||
| err := cp.cnrClient.Morph().NotarySignAndInvokeTX(e.NotaryRequest.MainTransaction, false) |
Contributor
There was a problem hiding this comment.
so 3rd party can add attribute to my container w/o my approval?
Contributor
Author
There was a problem hiding this comment.
I think no. I consider, we will check this with token parameter inside contact setAttribute, when it be done in contracts
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
smallhive
force-pushed
the
notary-set-attribute
branch
from
18979b1 to
eef8b6f
Compare
carpawell
reviewed
Dec 11, 2025
|
|
||
| // set attribute | ||
| p.SetRequestType(containerEvent.SetAttributeNotaryEvent) | ||
| p.SetParser(containerEvent.ParseSetAttribute) |
Member
There was a problem hiding this comment.
Suggested change
| p.SetParser(containerEvent.ParseSetAttribute) | |
| p.SetParser(containerEvent.ParseSetAttribute) | |
| pp = append(pp, p) |
|
|
||
| // ParseSetAttribute from NotaryEvent into container event structure. | ||
| func ParseSetAttribute(ne event.NotaryEvent) (event.Event, error) { | ||
| const expectedItemNumAnnounceLoad = 4 |
Member
There was a problem hiding this comment.
Suggested change
| const expectedItemNumAnnounceLoad = 4 | |
| const expectedItemNumSetAttribute = 4 |
| // SetAttribute represents structure of notification about modified container attributes | ||
| // coming from NeoFS Container contract. | ||
| type SetAttribute struct { | ||
| CID []byte |
Member
There was a problem hiding this comment.
we can validate it there. currently, any size of CID and any token can be signed by the alphabet and sent to the contract
Merged
Member
|
Replaced by #3733. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.