Skip to content

Prepare for binary header reading #3792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cthulhu-rider wants to merge 7 commits into
base: master
Choose a base branch
from

sn/storage: Avoid decoding of header binary for eACL recheck in HEAD

7c6ae5d
Select commit
Loading
Failed to load commit list.
Draft

Prepare for binary header reading #3792

sn/storage: Avoid decoding of header binary for eACL recheck in HEAD
7c6ae5d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 5, 2026 in 1s

25.30% (-0.40%) compared to bc322b8

View this Pull Request on Codecov

25.30% (-0.40%) compared to bc322b8

Details

Codecov Report

❌ Patch coverage is 13.57410% with 694 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.30%. Comparing base (bc322b8) to head (7c6ae5d).
⚠️ Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
internal/protobuf/api.go 0.00% 136 Missing ⚠️
pkg/services/object/acl/eacl/v2/object.go 0.00% 110 Missing ⚠️
internal/protobuf/parsers.go 0.00% 77 Missing ⚠️
internal/object/wire.go 28.73% 57 Missing and 5 partials ⚠️
pkg/local_object_storage/shard/head.go 0.00% 60 Missing ⚠️
pkg/services/object/protobuf.go 19.11% 55 Missing ⚠️
pkg/services/object/server.go 0.00% 40 Missing ⚠️
internal/protobuf/protobuf.go 0.00% 29 Missing ⚠️
pkg/local_object_storage/blobstor/fstree/head.go 60.81% 16 Missing and 13 partials ⚠️
internal/protobuf/buffers.go 0.00% 23 Missing ⚠️
... and 13 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3792      +/-   ##
==========================================
- Coverage   25.70%   25.30%   -0.40%     
==========================================
  Files         660      668       +8     
  Lines       42167    43427    +1260     
==========================================
+ Hits        10837    10989     +152     
- Misses      30348    31414    +1066     
- Partials      982     1024      +42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov