Merged
Conversation
1. base58 adds noticeable performance penalty and allocates. 2. There is no value added by hashing them, they're already random UUIDs. 3. As long as they're different hrw is ok. Signed-off-by: Roman Khimov <roman@nspcc.ru>
1. base58 allocates and spends some CPU cycles for something we don't need. 2. OID is a hash already, unique for each object, hashing it again adds no value. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
optimize-shard-hrw
branch
from
5f71644 to
7823814
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3794 +/- ##
=======================================
Coverage 25.67% 25.68%
=======================================
Files 660 660
Lines 42177 42177
=======================================
+ Hits 10830 10834 +4
+ Misses 30363 30361 -2
+ Partials 984 982 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
carpawell
approved these changes
Jan 30, 2026
End-rey
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks sorting for already stored objects, but this shouldn't be a big problem, objects are going to be accessible anyway and optimizing access is a separate issue (it can be suboptimal because of other reasons, evacuations/shard addition/deletion/ro/etc).