Merged
Conversation
Pool is naturally a part of shardWrapper, this patch simplifies locking and overall flow related to pools with no real logic changes. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Pure stylistics. Signed-off-by: Roman Khimov <roman@nspcc.ru>
This check was introduced in 21708d5 as a replacement for "already removed" check, but then putToShard() does the same check again and returns errExists if we have an object which then leads to successful put status. Which means that by ignoring the result here we waste a bit more resources to get to the same result. The suggestion is to stop doing that and return ok immediately if we know we have the object. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
requested review from
End-rey,
carpawell and
cthulhu-rider
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3797 +/- ##
==========================================
- Coverage 25.57% 25.52% -0.05%
==========================================
Files 660 660
Lines 42665 42636 -29
==========================================
- Hits 10910 10884 -26
+ Misses 30751 30749 -2
+ Partials 1004 1003 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
carpawell
approved these changes
Feb 3, 2026
End-rey
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functional changes.