Skip to content

morph: make client retry if fallback transaction was accepted #3798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carpawell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

morph: make client retry if fallback transaction was accepted #3798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ Changelog for NeoFS Node
- SN sorts shards identically when writing and reading EC parts (#3773)
- SN puts EC parts concurrently now (#3777)
- Optimized object-to-shard placement (#3794)
- SN retries notary requests if `insufficient amount of gas` error appears (#3739)

### Removed
- Deprecated `fschain_autodeploy`, `without_mainnet`, `governance.disable`, `fee.main_chain` and `contracts` IR config options (#3716)
Expand Down
4 changes: 3 additions & 1 deletion pkg/morph/client/static.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"errors"
"fmt"
"strings"
"time"

"github.com/cenkalti/backoff/v4"
Expand Down Expand Up @@ -202,7 +203,8 @@ func (s StaticClient) execWithBackoff(invokeFunc func() error) error {
return backoff.RetryNotify(func() error {
err := invokeFunc()
if err != nil {
if errors.Is(err, neorpc.ErrMempoolCapReached) {
if errors.Is(err, neorpc.ErrMempoolCapReached) ||
strings.Contains(err.Error(), "insufficient amount of gas") {
return err
}
return backoff.Permanent(err)
Expand Down
Loading