Undefine hl.h's _GUID to fix a Windows build error#39
Open
ThatCreeper wants to merge 1 commit intonspitko:masterfrom
Open
Undefine hl.h's _GUID to fix a Windows build error#39ThatCreeper wants to merge 1 commit intonspitko:masterfrom
ThatCreeper wants to merge 1 commit intonspitko:masterfrom
Conversation
Owner
|
This seems new, can you give a bit more info on what error you're seeing? Trying to figure out if this is an upstream problem with hl.h or something that's new in windows. We don't currently use GUIDs, but these are core type defines necessary to do hashlink plumbing, I'd like to avoid undefing any of them unless we have an unavoidable need to. edit: Once that PR comes through we can switch to the new defines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hl.h defining _GUID as "g" caused a bunch of build errors on my side. This change appears to fully fix that.