Added support for both Travis CI and CodeClimate Quality.#2
Open
hopeseekr wants to merge 1 commit intontzm:masterfrom
Open
Added support for both Travis CI and CodeClimate Quality.#2hopeseekr wants to merge 1 commit intontzm:masterfrom
hopeseekr wants to merge 1 commit intontzm:masterfrom
Conversation
ntzm
requested changes
Jun 22, 2019
| @@ -0,0 +1,15 @@ | |||
| { | |||
Owner
There was a problem hiding this comment.
I'm not interested in codeclimate quality, just the coverage
| - mkdir -p build/logs | ||
| - php vendor/bin/phpcs --standard=PSR12 src | ||
| - php vendor/bin/phpcs --standard=PSR1 tests | ||
| - php vendor/bin/phpstan analyze --level max src |
Owner
There was a problem hiding this comment.
I'm not interested in phpcs or phpstan at the moment, these lines can be removed
ntzm
reviewed
Jun 22, 2019
| language: php | ||
|
|
||
| php: | ||
| - '7.1' |
Owner
There was a problem hiding this comment.
I only want to support 7.2 and 7.3 for now, I'll be updating the composer.json to reflect this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is from phpexperts/skeleton v1.1.1.
This change is