Use setMacro to flag macros in the api namespace#185
Merged
carloshernandez2 merged 1 commit intomasterfrom Mar 6, 2025
Merged
Conversation
It also sets the meta value which was the only thing that was being done before
7d7fb30 to
901fddc
Compare
santiagocabrera96
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
It is not possible to AOT-compile namespaces that use the defflow macro from the API namespace and get a faster development workflow as described here.
Description
Taking these namespaces as a starting point:
When running
compileondeath-by-compilation-clj.my-dear-testit successfully compiles and writes to disk. Then if I kill the REPL, modify the file and repeat the process, the following error is thrown:Solution
By calling the setMacro method on the Vars that correspond to macros in the API namespace, we can flag them as the compiler expects and also add the macro metadata.
References