Skip to content

Conversation

@jotare
Copy link
Contributor

@jotare jotare commented Oct 17, 2025

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team October 17, 2025 12:43
Copy link
Contributor

@javitonino javitonino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing logic first. If prewarm flag is updated, the SyncMetadata won't get refreshed. We need to tweak SyncMetadata::set so the config is updated if it changes.

@jotare jotare force-pushed the prewarming-shards branch from 179573d to 336e1e4 Compare October 23, 2025 10:06
@jotare jotare force-pushed the prewarming-shards-2 branch from ca1b135 to 12c2458 Compare October 23, 2025 10:09
Base automatically changed from prewarming-shards to main October 23, 2025 10:30
@jotare jotare force-pushed the prewarming-shards-2 branch from 12c2458 to 247cd81 Compare October 23, 2025 10:34
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 73.91304% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.97%. Comparing base (48a50e9) to head (247cd81).

Files with missing lines Patch % Lines
nidx/src/api/grpc.rs 0.00% 7 Missing ⚠️
nidx/src/api/shards.rs 76.19% 1 Missing and 4 partials ⚠️
nidx/nidx_vector/src/segment.rs 84.00% 3 Missing and 1 partial ⚠️
nidx/src/metadata/index.rs 83.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3334      +/-   ##
==========================================
- Coverage   86.01%   85.97%   -0.04%     
==========================================
  Files         530      530              
  Lines       43310    43373      +63     
  Branches    12097    12160      +63     
==========================================
+ Hits        37254    37292      +38     
- Misses       5467     5490      +23     
- Partials      589      591       +2     
Flag Coverage Δ
nidx 79.56% <73.91%> (-0.11%) ⬇️
nucliadb 74.90% <ø> (ø)
nucliadb-ingest 45.48% <ø> (ø)
nucliadb-reader 45.11% <ø> (ø)
nucliadb-search 49.44% <ø> (ø)
nucliadb-standalone 48.35% <ø> (ø)
nucliadb-train 45.90% <ø> (ø)
nucliadb-writer 49.08% <ø> (ø)
nucliadb_dataset 75.80% <ø> (ø)
nucliadb_models 79.73% <ø> (ø)
nucliadb_sdk 85.29% <ø> (ø)
nucliadb_telemetry 82.89% <ø> (ø)
nucliadb_utils 81.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants