feat: canvas scaling for "high quality" output#9
Open
WUGqnwvMQPzl wants to merge 1 commit intonulla2011:masterfrom
Open
feat: canvas scaling for "high quality" output#9WUGqnwvMQPzl wants to merge 1 commit intonulla2011:masterfrom
WUGqnwvMQPzl wants to merge 1 commit intonulla2011:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding canvas scaling option for someone doesn't satisfied with 250p output and someone using HiDPI screen.
Also hard-coded max width of the canvas element so scaling won't messing up the layout.
Side note: Be better to use SVG instead of PNG for halo and cross texture, there's another PR already doing that: #6
Preview
Default 1x output:
2x output:
