feat: implement safe deletion with trash/recycle bin suppor#39
Open
5angar1us wants to merge 3 commits intonumman-ali:mainfrom
Open
feat: implement safe deletion with trash/recycle bin suppor#395angar1us wants to merge 3 commits intonumman-ali:mainfrom
5angar1us wants to merge 3 commits intonumman-ali:mainfrom
Conversation
191e9a4 to
87c4e5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Enhanced existing
removeandmanagecommands with safer deletion behavior using system trash/recycle bin as default instead of permanent deletion.What: Added safe deletion support to
removeandmanagecommands using system trash/recycle bin as default, with --force flag for permanent deletion.Why:
Implementation:
safeDelete()function insrc/utils/trash.tsusingtrashpackage for cross-platform support--forceflag to bothmanageandremovecommands for permanent deletionDeleteOptionsinterface withpermanent?: booleanfieldTesting:
safeDeletefunctionAn important note from the author of
trash:From the project's Readme
Usage: