[FIX] Hugely degraded performance for the translation subquery inject… #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion in _generate_translated_field odoo#18679 It solves issue odoo#18679 (odoo#18679) on Odoo v10 Only works on PostgreSQL 9.5 or above
eantones
force-pushed
the
10.0-odoo-hugely_degraded_performance_in_translation_subquery
branch
from
9cde369 to
4e19dd0
Compare
|
Hi @eantones, Will you propose this PR to odoo/OCA repository instead of yours? If not we can do it. Regards |
Member
Author
|
you mean to propose to the Odoo official repo, right? I was going to do that a long time ago but after reading some comments on odoo#18679 like: I understood that they're never going to merge it, that's why I asked politely in odoo#18679 (comment). But we can try now, at least to have a PR in the official Odoo repo to merge directly on our repos or using tools like git-aggregator. What do you think? Thanks! |
|
I think in OCA/OCB is more likely to be accepted. |
Member
Author
|
Ok, let's see what OCA/OCB says :-) |
Based on PlanetaTIC@3b3c9c6 correction. - Previous commit breaks import (from ONLY needed in where not exists) - Avoid duplicates in import (a slightly clearer and cleaner approach)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion in _generate_translated_field odoo#18679
It solves issue odoo#18679 (odoo#18679) on Odoo v10
Only works on PostgreSQL 9.5 or above
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr