[Halo96 v2] Add numpad 5 to leds in position_mode#8
Closed
tsleal29 wants to merge 1 commit intonuphy-src:nuphy-keyboardsfrom
tsleal29:nuphy-keyboards
Closed
[Halo96 v2] Add numpad 5 to leds in position_mode#8tsleal29 wants to merge 1 commit intonuphy-src:nuphy-keyboardsfrom tsleal29:nuphy-keyboards
tsleal29 wants to merge 1 commit intonuphy-src:nuphy-keyboardsfrom
tsleal29:nuphy-keyboards
Conversation
Author
|
@nuphy-src It would indeed be nice if you could update the algorithm in the repo 🙏 |
starryalley
pushed a commit
to starryalley/qmk_firmware
that referenced
this pull request
Sep 5, 2024
…switch was mirrored (nuphy-src#8)
Author
|
Closing the PR as it seems to have been fixed by @nuphy-src in their last commit. |
Owner
Thank you for your support, the issue of num has been solved, With this version of repo, can you detect double taps problems ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi NuPhy team,
I recently bought a Halo96 v2 and one of the features I was excited about was the illuminated homing keys.
Sadly the numpad 5 key does not light up as the F, J and up arrow, although on your website we can see the 5 key also beautifully lit in the pictures.
I opened this PR in hopes of fixing this issue.
I tested the updated firmware on my keyboard and everything seems to be working fine.
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Test