#3967: get credential status from local store for issued VCs (did:web)

[reinkrul]

Fixes #3967

[qltysh]

2 new issues

Tool	Category	Rule	Count
qlty	Structure	Function with many returns (count = 6): SearchIssuedVCs	2

[qltysh]

Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 0.01%.

Modified Files with Diff Coverage (5)

Rating	File	% Diff	Uncovered Line #s
	vcr/api/vcr/v2/api.go	75.0%	262-263
	vcr/issuer/sql_store.go	100.0%
	vcr/issuer/leia_store.go	77.8%	159-160
	vcr/issuer/issuer.go	89.2%	107-108, 121-122
	vcr/revocation/statuslist2021_issuer.go	95.0%	479
	Total	88.2%

🤖 Increase coverage with AI coding...

In the `iss3967-issued-vc-status` branch, add test coverage for this new code:

- `vcr/api/vcr/v2/api.go` -- Line 262-263
- `vcr/issuer/issuer.go` -- Lines 107-108 and 121-122
- `vcr/issuer/leia_store.go` -- Line 159-160
- `vcr/revocation/statuslist2021_issuer.go` -- Line 479

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

[stevenvegt]

can we somehow create a unique index on the table so that is would be impossible to have multiple revocations per VC?

[reinkrul]

As there are multiple statuslist reasons (e.g. suspended, revoked), there can be multiple statuslist entries (first suspended, then revoked). We don't actively use it, but I don't think it's smart to limit the current setup to only 1 statuslist entry, since it won't make things better, but might break things in future.

[stevenvegt]

I'm not sure how the ErrMultipleFound can be caused and fixed. But I prefer a setup in which this error should not be possible.