Skip to content

Conversation

@DDianovMD
Copy link

πŸ”— Linked issue

Issue #179

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • [ x] 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Added check to prevent calling .push({}) more then once on window.adsbygoogle object. Described error in the linked issue is happening only when for some reason push method is called more than once.

P.S. I'm not really familiar with Vue.js/Nuxt and for this reason unit test is not included in the PR. This fixed the problem for me in my NextJS project and I decided to contribute. I hope this fix the issue for you guys too.

…elements in the DOM with class=adsbygoogle already have ads in them. (nuxt-modules#179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant