remove "web" from reddit share url#572
remove "web" from reddit share url#572monika-with-a-k wants to merge 4 commits intonygardk:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 99146ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nygardk
left a comment
There was a problem hiding this comment.
Hello! Thank you for the contribution.
Not the that /web was included in the path recently in this PR.
Unfortunately, I don't have the time to investigate what is the correct url after all. It might depend on the case. Nevertheless, it would be good that we don't end up going back-and-forth with the url in different releases.
Any chance you could test the case "Verified that the link is now correctly populated in Reddit share previews (#547 )" and think of a solution that would in all cases?
|
Any plans to merge this? The current share button implementation is completely broken for me |
|
Just a friendly note to urge you to please merge this PR :-) |
|
@nygardk any chance we can get this merged? I have confirmed that https://www.reddit.com/submit is the correct url for sharing links. https://www.reddit.com/web/submit is no longer a valid working url. |
|
@nygardk I would also like to remind you to merge that, please! :) |
Remove "web" element from path for RedditShareButton
Current issue:
Fix: