Open
Conversation
…t frame is always a power of 2 which is required by the codec
run container as a service
|
Looks neat! |
twobob
reviewed
Nov 19, 2020
There was a problem hiding this comment.
// containerWidth = document.querySelector('#preview').clientWidth,
aspectRatio = height/width;
// containerWidth = containerWidth > 0 ? containerWidth : 640;
Is how I run this since that would actually cause the halfbars to offset to the right by a certain - annoying amount
although oddly just deleting 50 or so pixel from Client Width fixes the bar widths. I'll have to look into it.
@brizandrew we use your thing btw - very handy
twobob
reviewed
Nov 19, 2020
twobob
left a comment
twobob
left a comment
There was a problem hiding this comment.
The change in preview.js also has an odd effect of shrinking the backgrounds width when updating the caption text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The biggest issue for gaining widespread usage for this tool in my newsroom was the problem of editing JSON for non-coders. Even if all they wanted to change was a single image, they needed to open the JSON file. With this version, any user can edit themes and upload files to the proper directory on the server without needing the full server access required previously.
You can see a working version of this builder (with the actually audiogram generation disabled) on my website. And read more about these changes on my Medium post.
This PR also includes contributions by qrkourier.