feat: enhance array and URL encoding support in queryfilter#9
Open
stankolubomir wants to merge 1 commit intonytimes:mainfrom
Open
feat: enhance array and URL encoding support in queryfilter#9stankolubomir wants to merge 1 commit intonytimes:mainfrom
stankolubomir wants to merge 1 commit intonytimes:mainfrom
Conversation
- Add comprehensive URL decoding with percent-encoding (%XX) and plus-to-space conversion - Support indexed array notation (param[0], param[1]) alongside traditional arrays (param[]) - Enable mixing of array notations in same query string - Improve parameter matching logic for array filtering - Add extensive test coverage for URL decoding and array scenarios - Fix Dockerfile build compatibility across Varnish versions (6.0.14, 7.6.3, 7.7.1) - Update documentation with detailed examples and usage patterns This enhancement allows more flexible query parameter filtering with proper handling of URL-encoded parameters and comprehensive array support for modern web applications.
Author
|
Hello @andrew-canaday, could you please take a look at the implementation in the PR? |
|
Sure thing!
…On Tue, Sep 30, 2025 at 9:04 AM Lubomir Stanko ***@***.***> wrote:
*stankolubomir* left a comment (nytimes/libvmod-queryfilter#9)
<#9 (comment)>
Hello @andrew-canaday <https://github.com/andrew-canaday>, could you
please take a look at the implementation in the PR?
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXBJOB2G2UW3TYW7YW6NPL3VJ5VVAVCNFSM6AAAAACAF7JLA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNJSGAZDSNZQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hey, @stankolubomir, haha! I'm sorry! I keep forgetting: I lack permission to review or merge! You'll want to reach out to code@nytimes.com. (I'll reach out to some of my old colleagues to prod them). Thanks! |
Author
|
Thank you very much @andrew-canaday! I would be glad if you try to reach out some of them. Secondly I'll contact them also via email. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enhancement allows more flexible query parameter filtering with proper handling of URL-encoded parameters and comprehensive array support for modern web applications.