Skip to content

Conversation

@raphael-goetz
Copy link
Contributor

Resolves: #60 & #61

@raphael-goetz raphael-goetz requested a review from Copilot January 4, 2026 15:52
@raphael-goetz raphael-goetz linked an issue Jan 4, 2026 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements two changes: removing the Bukkit event bus pattern from the Listen stream and adding revision preservation capability to Objects. The Listen stream is simplified by removing the callback/acknowledgement mechanism and the priority-based registration system. A new preserve_previous_entry boolean field is added to the Object message to enable revision tracking.

  • Simplified Listen RPC by removing the event callback/acknowledgement pattern and ListenRegister message
  • Added preserve_previous_entry field to Object message for revision management
  • Updated service documentation to reflect the simplified Listen workflow

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
proto/v1/api.proto Added preserve_previous_entry field to Object; simplified ListenMessage from oneof to repeated string key_pattern; removed ListenRegister message; updated service documentation
sdk/go/v1/api.pb.go Generated Go code reflecting proto changes - new field, simplified ListenMessage structure, removed ListenRegister type and related code
sdk/go/v1/api_grpc.pb.go Updated gRPC service interface comments to reflect simplified Listen workflow without callback pattern
sdk/openapi/octopus.swagger.json Removed obsolete schema definitions (protobufNullValue, v1Entry, v1EventCall, v1GetResponse, v1ListenRegister, v1Object, v1PageInfo, v1Paginator)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

raphael-goetz and others added 5 commits January 4, 2026 16:59
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@raphael-goetz raphael-goetz merged commit 2d6d5c8 into main Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add withRevision to object drop: remove bukkit event bus pattern

2 participants