-
Notifications
You must be signed in to change notification settings - Fork 0
Revision Tag & Drop Bukkit Event Bus Pattern #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements two changes: removing the Bukkit event bus pattern from the Listen stream and adding revision preservation capability to Objects. The Listen stream is simplified by removing the callback/acknowledgement mechanism and the priority-based registration system. A new preserve_previous_entry boolean field is added to the Object message to enable revision tracking.
- Simplified Listen RPC by removing the event callback/acknowledgement pattern and ListenRegister message
- Added
preserve_previous_entryfield to Object message for revision management - Updated service documentation to reflect the simplified Listen workflow
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| proto/v1/api.proto | Added preserve_previous_entry field to Object; simplified ListenMessage from oneof to repeated string key_pattern; removed ListenRegister message; updated service documentation |
| sdk/go/v1/api.pb.go | Generated Go code reflecting proto changes - new field, simplified ListenMessage structure, removed ListenRegister type and related code |
| sdk/go/v1/api_grpc.pb.go | Updated gRPC service interface comments to reflect simplified Listen workflow without callback pattern |
| sdk/openapi/octopus.swagger.json | Removed obsolete schema definitions (protobufNullValue, v1Entry, v1EventCall, v1GetResponse, v1ListenRegister, v1Object, v1PageInfo, v1Paginator) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Resolves: #60 & #61