Names Changed #15
Open
Names Changed #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bandlimited Sawtooth
Owner
|
Cheers Bastiaan. As there's quite a lot here I'll pull it into a review branch and have a proper look when I have a moment - probably next week some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Joe, i changed the function names according to your suggestion, and I found a solution for the "Filter-inside-a-filter"-problem, namely, implementing the Filter ad-hoc (which isn't too hard with a leaky integrator).
There's still a few issues, especially with the triangular-wave generator, which are "fixed" for now (at least inaudible, if not understood and controlled) - but this is something for the future.