Skip to content

Update template to use internal hex parser #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ennsharma wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update template to use internal hex parser #7

ennsharma wants to merge 1 commit into from

Conversation

@ennsharma
Copy link
Contributor

@ennsharma ennsharma commented Oct 19, 2019

Nit

@ennsharma ennsharma requested a review from nhynes October 19, 2019 00:16
nhynes
nhynes reviewed Oct 19, 2019
View reviewed changes
Copy link
Contributor

@nhynes nhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to use native apis where possible. They're more introspectable in addition to being more efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nhynes nhynes nhynes left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ennsharma @nhynes