[Android]: Replace deprecated drawing cache with Canvas#20
Open
saheem128 wants to merge 1 commit intooblador:masterfrom
Open
[Android]: Replace deprecated drawing cache with Canvas#20saheem128 wants to merge 1 commit intooblador:masterfrom
saheem128 wants to merge 1 commit intooblador:masterfrom
Conversation
|
Were you able to zoom the image from the pivot point instead of the center using Canvas? |
Author
No! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in here:
This commit modifies the
startGesturemethod in the PinchableView class to use aCanvasfor creating a bitmap snapshot of the view. The previous implementation used the now-deprecated drawing cache, which could lead to compatibility and performance issues, especially in newer Android versions.My motivation:
Whenever I pinch an image and then change the image dynamically, it would return the old image on the next pinch geasture. Now, that could be solved by simply writing
v.invalidate()in thestartGesturemethod to kind of make it redraw the view, but doing it inCanvasalready solved my issue.