Merged
Conversation
The zeroed memory hack only applies on Windows if using CEF older than 3770, which we no longer support.
Assume we're always using CEF 5060 or newer.
Assume we're always using CEF 5060 or newer.
RytoEX
added
the
Code Cleanup
Assume we're always using CEF 5060 or newer. The check regarding ENABLE_WASHIDDEN is left intact on purpose so that it can be removed separately.
ENABLE_WASHIDDEN is defined to 1 for CEF 90+ (4430+), which we always use. Remove it and any code that would not be executed due to this value.
Remove ENABLE_LOCAL_FILE_URL_SCHEME. ENABLE_LOCAL_FILE_URL_SCHEME is defined to 0 for CEF 95+ (4638+), which we always use. Remove it and any code that would not be executed due to this value.
Assume CEF 5060 is the oldest build we support.
RytoEX
force-pushed
the
remove-old-cef-support
branch
from
6286dd5 to
8d32c82
Compare
WizardCM
approved these changes
Aug 23, 2025
Member
WizardCM
left a comment
WizardCM
left a comment
There was a problem hiding this comment.
Diff looks correct, removes any code older than 5060.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove support for CEF versions older than 95/5060. This includes removing:
Motivation and Context
We currently only support building against CEF 95/5060 and up. We actually only target much more recent versions, but we had previously settled on pruning pre-5060 code at some point in the future, and I wanted to keep to that scope.
Some lower bounds checks were left in place for now to (hopefully) maintain clarity with those checks.
How Has This Been Tested?
Compiled and ran on Windows 11.
cc @pkviet
Types of changes
Checklist: