Skip to content

obs-vst: Get devicePixelRatio from correct device #10212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tom-Evers wants to merge 1 commit into from
Closed

obs-vst: Get devicePixelRatio from correct device #10212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions plugins/obs-vst/win/EditorWidget-win.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ void EditorWidget::buildEffectContainer(AEffect *effect)
LONG_PTR wndPtr = (LONG_PTR)effect;
SetWindowLongPtr(windowHandle, -21 /*GWLP_USERDATA*/, wndPtr);

QWidget *widget = QWidget::createWindowContainer(
QWindow::fromWinId((WId)windowHandle), nullptr);
QWindow *window = QWindow::fromWinId((WId)windowHandle);
QWidget *widget = QWidget::createWindowContainer(window, nullptr);
widget->move(0, 0);
QGridLayout *layout = new QGridLayout();
layout->setContentsMargins(0, 0, 0, 0);
Expand All @@ -52,7 +52,7 @@ void EditorWidget::buildEffectContainer(AEffect *effect)
// on Windows, the size reported by 'effect' is larger than
// its actuall size by a factor of the monitor's ui scale,
// so the window size should be divided by the factor
qreal scale_factor = devicePixelRatioF();
qreal scale_factor = window->devicePixelRatio();
int width = vstRect->right - vstRect->left;
int height = vstRect->bottom - vstRect->top;
width = static_cast<int>(width / scale_factor);
Expand Down Expand Up @@ -81,7 +81,8 @@ void EditorWidget::handleResizeRequest(int, int)
// on Windows, the size reported by 'effect' is larger than
// its actuall size by a factor of the monitor's ui scale,
// so the window size should be divided by the factor
qreal scale_factor = devicePixelRatioF();
QWindow *window = QWindow::fromWinId((WId)windowHandle);
qreal scale_factor = window->devicePixelRatio();
int width = rec->right - rec->left;
int height = rec->bottom - rec->top;
width = static_cast<int>(width / scale_factor);
Expand Down