UI: Create OBS Studio folder for default recording location#10974
UI: Create OBS Studio folder for default recording location#10974Warchamp7 wants to merge 1 commit intoobsproject:masterfrom
Conversation
| if (!MakeRecordingDir()) | ||
| throw "Failed to create recording directory"; |
There was a problem hiding this comment.
This should be unnecessary as the directory is created on demand when a recording is started. OBS should not create an empty folder in the user's video folder just from being run.
There was a problem hiding this comment.
-
It does not create the folder on demand in my testing
-
I disagree and believe the folder should be initialized when OBS first runs like any app other storage location
There was a problem hiding this comment.
This isn't an app storage location though, this is the user's data folders. Well-designed apps should respect a user's folder layout and not create empty files and directories.
There was a problem hiding this comment.
Do you have some sort of guidance or documentation from Microsoft about that?
I have multiple applications on my system that have created folders for themselves in the Videos library location
There was a problem hiding this comment.
It's just good behavior, just because other apps are shitty doesn't mean we should also be shitty. There's plenty of evidence of of users who desire such behavior from their apps.
There was a problem hiding this comment.
One's shitty behaviour is another's expected behaviour though. And by that token I'd rather have an application create files in its own managed subdirectory than mess up the root of a data storage location.
I do agree that the directory should be created upon first use though. I don't remember Shadowplay creating directories for recordings or highlights until I actually triggered either.
There was a problem hiding this comment.
I concur with first use, as a user who does not enjoy all the random empty folders I have no intention of using.
Warchamp7
force-pushed
the
obs-recordings-path
branch
from
60f7a82 to
2336f81
Compare
Warchamp7
force-pushed
the
obs-recordings-path
branch
from
2336f81 to
1348efb
Compare
Warchamp7
added
the
UI/UX
| return getenv("HOME"); | ||
| if (moviesDirectory) { | ||
| const string videoSavePath = | ||
| [moviesDirectory URLByAppendingPathComponent:@"OBS-Studio" isDirectory:YES].path.fileSystemRepresentation; |
There was a problem hiding this comment.
| [moviesDirectory URLByAppendingPathComponent:@"OBS-Studio" isDirectory:YES].path.fileSystemRepresentation; | |
| [moviesDirectory URLByAppendingPathComponent:@"OBS Studio" isDirectory:YES].path.fileSystemRepresentation; |
Shouldn't this just be "OBS Studio"? Spaces are fine to pass as a component to this function, and I'm not aware of any issues with spaces in folder names for OBS.
|
Better approach to the underlying problem in #12395 |
7 participants
Description
This updates the default directory for recordings to be a newly created
OBS Studiofolder inside the default directory%UserProfile%/Videos/OBS Studioon Windows/home/<User>/OBS Studioon Linux (?)/Users/<User>/Movies/OBS Studioon macOS (?)Code for Linux and mac will need review and suggestions because I am completely guessing there and it will almost certainly not compile.
Motivation and Context
Better organization for users
How Has This Been Tested?
Tested on Windows.
Ensured the directory is created during initial startup and properly set for new Profiles.
Types of changes
Checklist: