frontend: Move Preview into dock widget#12190
Draft
Warchamp7 wants to merge 1 commit intoobsproject:masterfrom
Draft
frontend: Move Preview into dock widget#12190Warchamp7 wants to merge 1 commit intoobsproject:masterfrom
Warchamp7 wants to merge 1 commit intoobsproject:masterfrom
Conversation
Contributor
|
By putting everything in a single dock area "Full-Height docks" option will not be functional anymore. OBSBasic::AddDockWidget might need to force to bottom area too for docks from plugins |
Member
Author
Correct, the option won't be needed anymore, since the preview not being the central widget will no longer restrict docks from being laid out in the way that full height docks addressed.
Yep, this is also planned. |
c63b598 to
06c3433
Compare
6 tasks
19eb366 to
3b0f955
Compare
3b0f955 to
edf2d9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the widgets for the preview into an OBSDock within the main window. Instead of the preview being the centralwidget, a new dummy one is added to the top of the window, and all docks have their allowedAreas set to
BottomDockWidgetAreaonly.Depends on #12188
Note
Still need to update Browser Docks to have their allowedAreas set correctly, as well as probably override the
addDockmethod to force set it.The Preview dock cannot be moved, undocked or hidden and has an empty widget for it's title bar. Functionally it is effectively identical to before.
Motivation and Context
This makes certain dock layouts much more intuitive to set up, moves us a small step closer to more encapsulation of main window functionality. This is also a requirement for additional UI changes in the future that I am experimenting with involving either a top toolbar or a dedicated sidebar as a revamped home for Outputs, contextual controls, and eventually canvases.
How Has This Been Tested?
Interacted with the preview and ensured functionality matched main.
Types of changes
Checklist: